Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1416 #1460

Merged
merged 2 commits into from
Dec 7, 2016
Merged

Fix #1416 #1460

merged 2 commits into from
Dec 7, 2016

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 7, 2016

Fixes #1416

@codecov-io
Copy link

codecov-io commented Dec 7, 2016 •
edited
Loading

Current coverage is 98.83% (diff: 100%)

Merging #1460 into master will increase coverage by <.01%

@@             master      #1460   diff @@
==========================================
  Files            30         30          
  Lines          6948       6951     +3   
  Methods           0          0          
  Messages          0          0          
  Branches       1151       1152     +1   
==========================================
+ Hits           6867       6870     +3   
  Misses           40         40          
  Partials         41         41

Powered by Codecov. Last update 36b1432...fdba13d

@asvetlov asvetlov merged commit 34592c2 into master Dec 7, 2016
@asvetlov asvetlov deleted the fix_1416 branch December 7, 2016 19:53
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's impossible to throw web_exceptions.* from router's resolve()
2 participants
@asvetlov @codecov-io